]> www.infradead.org Git - users/jedix/linux-maple.git/commit
USB: serial: io_edgeport: fix memory leaks in probe error path
authorJohan Hovold <johan@kernel.org>
Sun, 8 May 2016 18:07:57 +0000 (20:07 +0200)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:21:54 +0000 (17:21 -0500)
commitac0701e62c2300b67285ce226fc8a9af73a46925
treeacae8ecbc3afb9e718ee1c1649de4c0a1e62a052
parent034eb1c45d6bb0df4378cf46513ee207c0b1e7f9
USB: serial: io_edgeport: fix memory leaks in probe error path

Orabug: 25256928

[ Upstream commit c8d62957d450cc1a22ce3242908709fe367ddc8e ]

URBs and buffers allocated in attach for Epic devices would never be
deallocated in case of a later probe error (e.g. failure to allocate
minor numbers) as disconnect is then never called.

Fix by moving deallocation to release and making sure that the
URBs are first unlinked.

Fixes: f9c99bb8b3a1 ("USB: usb-serial: replace shutdown with disconnect,
release")
Cc: stable <stable@vger.kernel.org> # v2.6.31
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 90eb29f547e7de02d663257a3e8b042b80940925)
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
drivers/usb/serial/io_edgeport.c