]> www.infradead.org Git - users/hch/dma-mapping.git/commit
net: add more sanity checks to qdisc_pkt_len_init()
authorEric Dumazet <edumazet@google.com>
Tue, 24 Sep 2024 15:02:57 +0000 (15:02 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 1 Oct 2024 09:47:05 +0000 (11:47 +0200)
commitab9a9a9e9647392a19e7a885b08000e89c86b535
treea1459d6153629dc225628a0994b929b7251e227a
parentc20029db28399ecc50e556964eaba75c43b1e2f1
net: add more sanity checks to qdisc_pkt_len_init()

One path takes care of SKB_GSO_DODGY, assuming
skb->len is bigger than hdr_len.

virtio_net_hdr_to_skb() does not fully dissect TCP headers,
it only make sure it is at least 20 bytes.

It is possible for an user to provide a malicious 'GSO' packet,
total length of 80 bytes.

- 20 bytes of IPv4 header
- 60 bytes TCP header
- a small gso_size like 8

virtio_net_hdr_to_skb() would declare this packet as a normal
GSO packet, because it would see 40 bytes of payload,
bigger than gso_size.

We need to make detect this case to not underflow
qdisc_skb_cb(skb)->pkt_len.

Fixes: 1def9238d4aa ("net_sched: more precise pkt_len computation")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/core/dev.c