]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ACPI: property: Fix return value for nval == 0 in acpi_data_prop_read()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 3 Feb 2025 19:46:29 +0000 (21:46 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 5 Feb 2025 20:09:28 +0000 (21:09 +0100)
commitab930483eca9f3e816c35824b5868599af0c61d7
tree2005a163f1bc8172d29f9c84748c044fdc335940
parent2014c95afecee3e76ca4a56956a936e23283f05b
ACPI: property: Fix return value for nval == 0 in acpi_data_prop_read()

While analysing code for software and OF node for the corner case when
caller asks to read zero items in the supposed to be an array of values
I found that ACPI behaves differently to what OF does, i.e.

 1. It returns -EINVAL when caller asks to read zero items from integer
    array, while OF returns 0, if no other errors happened.

 2. It returns -EINVAL when caller asks to read zero items from string
    array, while OF returns -ENODATA, if no other errors happened.

Amend ACPI implementation to follow what OF does.

Fixes: b31384fa5de3 ("Driver core: Unified device properties interface for platform firmware")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20250203194629.3731895-1-andriy.shevchenko@linux.intel.com
[ rjw: Added empty line after a conditional ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/property.c