]> www.infradead.org Git - users/jedix/linux-maple.git/commit
vmxnet3: prevent building with 64K pages
authorArnd Bergmann <arnd@arndb.de>
Fri, 17 Feb 2017 15:08:30 +0000 (16:08 +0100)
committerChuck Anderson <chuck.anderson@oracle.com>
Mon, 6 Mar 2017 21:30:12 +0000 (13:30 -0800)
commitab8e0a40325faf437170a6baac78e4e2caaaff76
tree9e153aa652ecabb1220906e81affb3bf637b9570
parenta7c76f2c3040266393d8481323e7d956aed83ddb
vmxnet3: prevent building with 64K pages

Orabug: 25639933

I got a warning about broken code on ARM64 with 64K pages:

drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init':
drivers/net/vmxnet3/vmxnet3_drv.c:1679:29: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
    rq->buf_info[0][i].len = PAGE_SIZE;

'len' here is a 16-bit integer, so this clearly won't work. I don't think
this driver is used much on anything other than x86, so there is no need
to fix this properly and we can work around it with a Kconfig dependency
to forbid known-broken configurations. qemu in theory supports it on
other architectures too, but presumably only for compatibility with x86
guests that also run on vmware.

CONFIG_PAGE_SIZE_64KB is used on hexagon, mips, sh and tile, the other
symbols are architecture-specific names for the same thing.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit fbdf0e28d061708cf18ba0f8e0db5360dc9a15b9)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/net/Kconfig