]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rust: fix the default format for CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT
authorMasahiro Yamada <masahiroy@kernel.org>
Sat, 27 Jul 2024 14:03:00 +0000 (23:03 +0900)
committerMiguel Ojeda <ojeda@kernel.org>
Sun, 28 Jul 2024 22:48:26 +0000 (00:48 +0200)
commitaacf93e87f0d808ef46e621aa56caea336b4433c
tree7652e04e045cc1c5b3ba39134be52ae4bf77eb63
parent5ce86c6c861352c9346ebb5c96ed70cb67414aa3
rust: fix the default format for CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT

Another oddity in these config entries is their default value can fall
back to 'n', which is a value for bool or tristate symbols.

The '|| echo n' is an incorrect workaround to avoid the syntax error.
This is not a big deal, as the entry is hidden by 'depends on RUST' in
situations where '$(RUSTC) --version' or '$(BINDGEN) --version' fails.
Anyway, it looks odd.

The default of a string type symbol should be a double-quoted string
literal. Turn it into an empty string when the version command fails.

Fixes: 2f7ab1267dc9 ("Kbuild: add Rust support")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Link: https://lore.kernel.org/r/20240727140302.1806011-2-masahiroy@kernel.org
[ Rebased on top of v6.11-rc1. - Miguel ]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
init/Kconfig