]> www.infradead.org Git - users/jedix/linux-maple.git/commit
vfio/pci: clean up a type in vfio_pci_ioctl_pci_hot_reset_groups()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 12 Sep 2024 08:49:10 +0000 (11:49 +0300)
committerAlex Williamson <alex.williamson@redhat.com>
Thu, 12 Sep 2024 20:15:07 +0000 (14:15 -0600)
commitaab439ffa1ca1067c0114773d4044828fab582af
tree58f3212ccc43db8bd46160a18e631beaedbbdeb8
parent27a8204b26ac009e47e0bcde4cd24ff69d96fccf
vfio/pci: clean up a type in vfio_pci_ioctl_pci_hot_reset_groups()

The "array_count" value comes from the copy_from_user() in
vfio_pci_ioctl_pci_hot_reset().  If the user passes a value larger than
INT_MAX then we'll pass a negative value to kcalloc() which triggers an
allocation failure and a stack trace.

It's better to make the type unsigned so that if (array_count > count)
returns -EINVAL instead.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/262ada03-d848-4369-9c37-81edeeed2da2@stanley.mountain
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/pci/vfio_pci_core.c