]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/vkms: fix variable dereferenced before check warning
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thu, 8 Sep 2022 10:56:23 +0000 (03:56 -0700)
committerMelissa Wen <melissa.srw@gmail.com>
Sat, 10 Sep 2022 22:18:56 +0000 (21:18 -0100)
commitaaa65520280e96dc47fa5065b74bddff30279abe
tree6e6249617f012b5b8cbb7ff374745362b0ebc018
parentfa47573b04a35078953be5f81a78f22c96358817
drm/vkms: fix variable dereferenced before check warning

Smatch warns:

drivers/gpu/drm/vkms/vkms_plane.c:110 vkms_plane_atomic_update() warn:
 variable dereferenced before check 'fb' (see line 108)

Fix the warning by moving the dereference after the NULL check.

Fixes: 8ba1648567e2 ("drm: vkms: Refactor the plane composer to accept new formats")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220908105623.72777-1-harshit.m.mogalapalli@oracle.com
drivers/gpu/drm/vkms/vkms_plane.c