]> www.infradead.org Git - users/jedix/linux-maple.git/commit
netlink: correct nlmsg size for multicast notifications
authorYuyang Huang <yuyanghuang@google.com>
Sat, 21 Dec 2024 10:00:07 +0000 (19:00 +0900)
committerJakub Kicinski <kuba@kernel.org>
Mon, 23 Dec 2024 18:26:43 +0000 (10:26 -0800)
commitaa4ad7c3f283fa94b80cf84605661700aa39d708
tree20dc0f538998486cdd628220b9d40fdb174db946
parentf288c7a1ba268a9ed58a7971142a98a1e41a3c73
netlink: correct nlmsg size for multicast notifications

Corrected the netlink message size calculation for multicast group
join/leave notifications. The previous calculation did not account for
the inclusion of both IPv4/IPv6 addresses and ifa_cacheinfo in the
payload. This fix ensures that the allocated message size is
sufficient to hold all necessary information.

This patch also includes the following improvements:
* Uses GFP_KERNEL instead of GFP_ATOMIC when holding the RTNL mutex.
* Uses nla_total_size(sizeof(struct in6_addr)) instead of
  nla_total_size(16).
* Removes unnecessary EXPORT_SYMBOL().

Fixes: 2c2b61d2138f ("netlink: add IGMP/MLD join/leave notifications")
Cc: Maciej Żenczykowski <maze@google.com>
Cc: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: Yuyang Huang <yuyanghuang@google.com>
Link: https://patch.msgid.link/20241221100007.1910089-1-yuyanghuang@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/igmp.c
net/ipv6/addrconf.c
net/ipv6/mcast.c