]> www.infradead.org Git - users/jedix/linux-maple.git/commit
netfs: Fix missing barriers by using clear_and_wake_up_bit()
authorDavid Howells <dhowells@redhat.com>
Fri, 13 Dec 2024 13:50:07 +0000 (13:50 +0000)
committerChristian Brauner <brauner@kernel.org>
Fri, 20 Dec 2024 21:07:57 +0000 (22:07 +0100)
commitaa3956418985bda1f68313eadde3267921847978
tree62176c015bdd64d9e60aff8f4862053752dcdfa6
parentf4d3cde410cc62b5483f59f0f3454a5c5203a2cb
netfs: Fix missing barriers by using clear_and_wake_up_bit()

Use clear_and_wake_up_bit() rather than something like:

clear_bit_unlock(NETFS_RREQ_IN_PROGRESS, &rreq->flags);
wake_up_bit(&rreq->flags, NETFS_RREQ_IN_PROGRESS);

as there needs to be a barrier inserted between which is present in
clear_and_wake_up_bit().

Fixes: 288ace2f57c9 ("netfs: New writeback implementation")
Fixes: ee4cdf7ba857 ("netfs: Speed up buffered reading")
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20241213135013.2964079-8-dhowells@redhat.com
Reviewed-by: Akira Yokosawa <akiyks@gmail.com>
cc: Zilin Guan <zilin@seu.edu.cn>
cc: Akira Yokosawa <akiyks@gmail.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/netfs/read_collect.c
fs/netfs/write_collect.c