]> www.infradead.org Git - users/jedix/linux-maple.git/commit
USB: serial: keyspan: fix use-after-free in probe error path
authorJohan Hovold <johan@kernel.org>
Sun, 8 May 2016 18:07:58 +0000 (20:07 +0200)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:21:54 +0000 (17:21 -0500)
commitaa0b662a86f5f9710f67282c0b989a8423fc95bd
treec7b916ddcfe369481d1eb11f01f2f5754c033fbd
parentac0701e62c2300b67285ce226fc8a9af73a46925
USB: serial: keyspan: fix use-after-free in probe error path

Orabug: 25256929

[ Upstream commit 35be1a71d70775e7bd7e45fa6d2897342ff4c9d2 ]

The interface instat and indat URBs were submitted in attach, but never
unlinked in release before deallocating the corresponding transfer
buffers.

In the case of a late probe error (e.g. due to failed minor allocation),
disconnect would not have been called before release, causing the
buffers to be freed while the URBs are still in use. We'd also end up
with active URBs for an unbound interface.

Fixes: f9c99bb8b3a1 ("USB: usb-serial: replace shutdown with disconnect,
release")
Cc: stable <stable@vger.kernel.org> # v2.6.31
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit d2e9eeb2504c73c09c415e5d4fc4cc33ffc4cb9f)
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
drivers/usb/serial/keyspan.c