]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: vicodec: allow en/decoder cmd w/o CAPTURE
authorDeborah Brouwer <deborah.brouwer@collabora.com>
Thu, 9 Nov 2023 18:48:38 +0000 (10:48 -0800)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Sun, 25 Aug 2024 06:15:24 +0000 (08:15 +0200)
commita9fef294e8b1e53a7ea733576dd4788c84ec8a21
tree57bba59cc8a567a1b73bd1fd889019b7b7d0a400
parenta043ea54bbb975ca9239c69fd17f430488d33522
media: vicodec: allow en/decoder cmd w/o CAPTURE

Vicodec will ignore en/decoder commands if the CAPTURE queue is not
streaming. But this prevents CMD_STOP from being used during a dynamic
resolution change to mark the last source buffer. Since CMD_STOP is
ignored, but doesn’t fail, there is no warning that the command needs to
be resent, and CAPTURE will continue to attempt to dequeue buffers
waiting, futilely, for one with V4L2_BUF_FLAG_LAST.

Fix this problem by carrying out en/decoder commands even if CAPTURE is
not streaming.

Fixes: d17589afa9706 vicodec: improve handling of ENC_CMD_STOP/START
Reported by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/test-drivers/vicodec/vicodec-core.c