]> www.infradead.org Git - users/jedix/linux-maple.git/commit
netpoll: Use rtnl_dereference() for npinfo pointer access
authorBreno Leitao <leitao@debian.org>
Tue, 3 Dec 2024 00:22:05 +0000 (16:22 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Dec 2024 02:41:37 +0000 (18:41 -0800)
commita9ab02ed97c654a9ea09afb3e6294cea3768c388
tree33e3a623ee029eb2eb5db74cdda20db004c65d84
parentbb18265c3aba92b91a1355609769f3e967b65dee
netpoll: Use rtnl_dereference() for npinfo pointer access

In the __netpoll_setup() function, when accessing the device's npinfo
pointer, replace rcu_access_pointer() with rtnl_dereference(). This
change is more appropriate, as suggested by Herbert Xu[1].

The function is called with the RTNL mutex held, and the pointer is
being dereferenced later, so, dereference earlier and just reuse the
pointer for the if/else.

The replacement ensures correct pointer access while maintaining
the existing locking and RCU semantics of the netpoll subsystem.

Link: https://lore.kernel.org/lkml/Zz1cKZYt1e7elibV@gondor.apana.org.au/
Suggested-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Link: https://patch.msgid.link/20241202-netpoll_rcu_herbet_fix-v2-1-2b9d58edc76a@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/netpoll.c