]> www.infradead.org Git - users/dwmw2/qemu.git/commit
hmp: do not crash on invalid SCSI hotplug
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 23 Nov 2012 15:56:18 +0000 (16:56 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 3 Dec 2012 20:27:39 +0000 (14:27 -0600)
commita99cb0d20a4868a31f294f5d1fd4fa3225ea70ab
treed12e7b7340017fa2b2fa1001c10914fc7ad9682a
parent5e19e498b4b2a31c985dc96b1aff078c34e40488
hmp: do not crash on invalid SCSI hotplug

Commit 0d93692 (qdev: Convert busses to QEMU Object Model, 2012-05-02)
removed a check on the type of the bus where a SCSI disk is hotplugged.
However, hot-plugging to the wrong kind of device now causes a crash
due to either a NULL pointer dereference (avoided by the previous patch)
or a failed QOM cast.

Instead, in this case we need to use object_dynamic_cast and check for
the result, similar to what was done before that commit.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
(cherry picked from commit b5007bcc9729acd995518c52eb1038c4d8416b5d)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/pci-hotplug.c