]> www.infradead.org Git - nvme.git/commit
drm/i915/dsb: Try to document that DSB_STATUS bit 16 is level triggered
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 11 Jun 2024 13:33:44 +0000 (16:33 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 27 Jun 2024 13:00:52 +0000 (16:00 +0300)
commita9422ec92a6388c8a19fad759f7ed0d533734cc6
treec68c194b8c06973d5786cac0976f28af830f0fc1
parentaaf9dc86bd806458f848c39057d59e5aa652a399
drm/i915/dsb: Try to document that DSB_STATUS bit 16 is level triggered

DSB_STATUS bit 16 is supposed to be a sticky bit informing us whether
the DSB was idle or not when the pipe's delayed vblank (when double
buffered registers latch) occurred. Unfortunately it turns out this
is a level triggred signal, ie. the bit will be set whenever the
DSB is busy during the scanline window between start of delayed
vblank and vtotal. Try to document that fact by renaming the bit.

Sadly this also thwarts my plan to use this bit to sanity check
that the (to be introduced) DSB based vblank evasion did its job
correctly. That would require an edge triggered signal instead.
So looks like we'll have to rely mostly on luck instead :(

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240611133344.30673-12-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_dsb_regs.h