]> www.infradead.org Git - users/dwmw2/linux.git/commit
ratelimit: Warn if ->interval or ->burst are negative
authorPetr Mladek <pmladek@suse.com>
Thu, 24 Apr 2025 18:19:13 +0000 (11:19 -0700)
committerPaul E. McKenney <paulmck@kernel.org>
Thu, 8 May 2025 23:13:27 +0000 (16:13 -0700)
commita940d145cc381c8cde0d0f7f9faf282fbab89bfb
treef5f30ed606643872412b66a86dad4b2bd6f435fa
parent96d366048fed6a70accf4ddb55c4c65ab27aa48f
ratelimit: Warn if ->interval or ->burst are negative

Currently, ___ratelimit() treats a negative ->interval or ->burst as
if it was zero, but this is an accident of the current implementation.
Therefore, splat in this case, which might have the benefit of detecting
use of uninitialized ratelimit_state structures on the one hand or easing
addition of new features on the other.

Link: https://lore.kernel.org/all/fbe93a52-365e-47fe-93a4-44a44547d601@paulmck-laptop/
Link: https://lore.kernel.org/all/20250423115409.3425-1-spasswolf@web.de/
Signed-off-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
lib/ratelimit.c