]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ASoC: fsl_micfil: Enable default case in micfil_set_quality()
authorNikita Zhandarovich <n.zhandarovich@fintech.ru>
Thu, 16 Jan 2025 14:24:36 +0000 (06:24 -0800)
committerMark Brown <broonie@kernel.org>
Mon, 3 Feb 2025 00:34:17 +0000 (00:34 +0000)
commita8c9a453387640dbe45761970f41301a6985e7fa
tree5c45027b2bdb650fb783daafeb5dfb9820e12e73
parent2014c95afecee3e76ca4a56956a936e23283f05b
ASoC: fsl_micfil: Enable default case in micfil_set_quality()

If 'micfil->quality' received from micfil_quality_set() somehow ends
up with an unpredictable value, switch() operator will fail to
initialize local variable qsel before regmap_update_bits() tries
to utilize it.

While it is unlikely, play it safe and enable a default case that
returns -EINVAL error.

Found by Linux Verification Center (linuxtesting.org) with static
analysis tool SVACE.

Fixes: bea1d61d5892 ("ASoC: fsl_micfil: rework quality setting")
Cc: stable@vger.kernel.org
Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
Link: https://patch.msgid.link/20250116142436.22389-1-n.zhandarovich@fintech.ru
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl_micfil.c