]> www.infradead.org Git - users/dwmw2/linux.git/commit
usb: cdc-wdm: close race between read and workqueue
authorOliver Neukum <oneukum@suse.com>
Thu, 14 Mar 2024 11:50:48 +0000 (12:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:19:32 +0000 (16:19 +0200)
commita86e54a345139f1a7668c9f83bdc7ac6f91b6f78
tree1714a174ce5a1ef237e1576f974b19563c3b0d08
parentac9b6b3e8d1237136c8ebf0fa1ce037dd7e2948f
usb: cdc-wdm: close race between read and workqueue

commit 339f83612f3a569b194680768b22bf113c26a29d upstream.

wdm_read() cannot race with itself. However, in
service_outstanding_interrupt() it can race with the
workqueue, which can be triggered by error handling.

Hence we need to make sure that the WDM_RESPONDING
flag is not just only set but tested.

Fixes: afba937e540c9 ("USB: CDC WDM driver")
Cc: stable <stable@kernel.org>
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Link: https://lore.kernel.org/r/20240314115132.3907-1-oneukum@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/cdc-wdm.c