]> www.infradead.org Git - users/willy/pagecache.git/commit
net: sfc: Correct key_len for efx_tc_ct_zone_ht_params
authorLiang Jie <liangjie@lixiang.com>
Mon, 30 Dec 2024 09:37:09 +0000 (17:37 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 3 Jan 2025 01:11:41 +0000 (17:11 -0800)
commita8620de72e5676993ec3a3b975f7c10908f5f60f
tree27059183f796a1b73ebe07fb16cb18f0197d600d
parent4f619d518db9cd1a933c3a095a5f95d0c1584ae8
net: sfc: Correct key_len for efx_tc_ct_zone_ht_params

In efx_tc_ct_zone_ht_params, the key_len was previously set to
offsetof(struct efx_tc_ct_zone, linkage). This calculation is incorrect
because it includes any padding between the zone field and the linkage
field due to structure alignment, which can vary between systems.

This patch updates key_len to use sizeof_field(struct efx_tc_ct_zone, zone)
, ensuring that the hash table correctly uses the zone as the key. This fix
prevents potential hash lookup errors and improves connection tracking
reliability.

Fixes: c3bb5c6acd4e ("sfc: functions to register for conntrack zone offload")
Signed-off-by: Liang Jie <liangjie@lixiang.com>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
Link: https://patch.msgid.link/20241230093709.3226854-1-buaajxlj@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sfc/tc_conntrack.c