]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf header: Fix one memory leakage in process_bpf_prog_info()
authorZhongqiu Han <quic_zhonhan@quicinc.com>
Thu, 5 Dec 2024 08:44:59 +0000 (16:44 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 10 Dec 2024 19:59:32 +0000 (16:59 -0300)
commita7da6c7030e1aec32f0a41c7b4fa70ec96042019
tree3b25b136d3a9d8fdb89a5f44640b5f357220dffb
parent875d22980a062521beed7b5df71fb13a1af15d83
perf header: Fix one memory leakage in process_bpf_prog_info()

Function __perf_env__insert_bpf_prog_info() will return without inserting
bpf prog info node into perf env again due to a duplicate bpf prog info
node insertion, causing the temporary info_linear and info_node memory to
leak. Modify the return type of this function to bool and add a check to
ensure the memory is freed if the function returns false.

Fixes: 606f972b1361f477 ("perf bpf: Save bpf_prog_info information as headers to perf.data")
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Zhongqiu Han <quic_zhonhan@quicinc.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <song@kernel.org>
Cc: Yicong Yang <yangyicong@hisilicon.com>
Link: https://lore.kernel.org/r/20241205084500.823660-3-quic_zhonhan@quicinc.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/env.c
tools/perf/util/env.h
tools/perf/util/header.c