]> www.infradead.org Git - users/jedix/linux-maple.git/commit
nfsd: fix undefined behavior in nfsd4_layout_verify
authorAri Kauppi <ari@synopsys.com>
Fri, 5 May 2017 20:07:55 +0000 (16:07 -0400)
committerKirtikar Kashyap <kirtikar.kashyap@oracle.com>
Fri, 4 Aug 2017 19:54:50 +0000 (12:54 -0700)
commita7705157664b489cd280b5ab1c384ede66043ed1
tree48d77320a389b0e72b41f6078b9a4fe94a5a0082
parent6f48aa835bda2bed7c6e1f222355f0ccff1b5e2d
nfsd: fix undefined behavior in nfsd4_layout_verify

  UBSAN: Undefined behaviour in fs/nfsd/nfs4proc.c:1262:34
  shift exponent 128 is too large for 32-bit type 'int'

Depending on compiler+architecture, this may cause the check for
layout_type to succeed for overly large values (which seems to be the
case with amd64). The large value will be later used in de-referencing
nfsd4_layout_ops for function pointers.

Reported-by: Jani Tuovila <tuovila@synopsys.com>
Signed-off-by: Ari Kauppi <ari@synopsys.com>
[colin.king@canonical.com: use LAYOUT_TYPE_MAX instead of 32]
Cc: stable@vger.kernel.org
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
(cherry picked from commit b550a32e60a4941994b437a8d662432a486235a5)

Orabug: 26376568
CVE: CVE-2017-8797

Signed-off-by: Kirtikar Kashyap <kirtikar.kashyap@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
 Conflicts:
fs/nfsd/nfs4proc.c
fs/nfsd/nfs4proc.c