]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rds: tcp: use sock_create_lite() to create the accept socket
authorSowmini Varadhan <sowmini.varadhan@oracle.com>
Thu, 6 Jul 2017 15:15:06 +0000 (08:15 -0700)
committerChuck Anderson <chuck.anderson@oracle.com>
Wed, 26 Jul 2017 03:56:37 +0000 (20:56 -0700)
commita670499f5a9a7b3cbe515685e097dc518a454010
tree09ce36d8bb367a325e7968d3b5e2ec051f9abf33
parent0d47de1c1f24fad6064f5202e64b87a044c4fcb1
rds: tcp: use sock_create_lite() to create the accept socket

There are two problems with calling sock_create_kern() from
rds_tcp_accept_one()
1. it sets up a new_sock->sk that is wasteful, because this ->sk
   is going to get replaced by inet_accept() in the subsequent ->accept()
2. The new_sock->sk is a leaked reference in sock_graft() which
   expects to find a null parent->sk

Avoid these problems by calling sock_create_lite().

Orabug: 26477756

Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
net/rds/tcp_listen.c