]> www.infradead.org Git - users/hch/misc.git/commit
perf/x86/intel: Don't clear perf metrics overflow bit unconditionally
authorDapeng Mi <dapeng1.mi@linux.intel.com>
Tue, 15 Apr 2025 10:41:34 +0000 (10:41 +0000)
committerIngo Molnar <mingo@kernel.org>
Thu, 17 Apr 2025 12:19:07 +0000 (14:19 +0200)
commita5f5e1238f4ff919816f69e77d2537a48911767b
tree7d2b3929f9bda5f2c30ecbc9b454a8134418d2cf
parent506f981ab40f0b03a11a640cfd77f48b09aff330
perf/x86/intel: Don't clear perf metrics overflow bit unconditionally

The below code would always unconditionally clear other status bits like
perf metrics overflow bit once PEBS buffer overflows:

        status &= intel_ctrl | GLOBAL_STATUS_TRACE_TOPAPMI;

This is incorrect. Perf metrics overflow bit should be cleared only when
fixed counter 3 in PEBS counter group. Otherwise perf metrics overflow
could be missed to handle.

Closes: https://lore.kernel.org/all/20250225110012.GK31462@noisy.programming.kicks-ass.net/
Fixes: 7b2c05a15d29 ("perf/x86/intel: Generic support for hardware TopDown metrics")
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20250415104135.318169-1-dapeng1.mi@linux.intel.com
arch/x86/events/intel/core.c