]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xfs: remove NULL pointer checks in xfs_mru_cache_insert
authorChristoph Hellwig <hch@lst.de>
Thu, 5 Jun 2025 06:16:28 +0000 (08:16 +0200)
committerCarlos Maiolino <cem@kernel.org>
Mon, 16 Jun 2025 08:05:08 +0000 (10:05 +0200)
commita593c89ac5a417605b165cbc9768b3663ab4d8ad
treefb805ee8763778adae3b204d24b4d8f52907dbf5
parentb0f77d301eb2b4e1fc816f33ade8519ae7f894f4
xfs: remove NULL pointer checks in xfs_mru_cache_insert

Remove the check for a NULL mru or mru->list in xfs_mru_cache_insert
as this API misused lead to a direct NULL pointer dereference on first
use and is not user triggerable.  As a smatch run by Dan points out
with the recent cleanup it would otherwise try to free the object we
just determined to be NULL for this impossible to reach case.

Fixes: 70b95cb86513 ("xfs: free the item in xfs_mru_cache_insert on failure")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hans Holmberg <hans.holmberg@wdc.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_mru_cache.c