]> www.infradead.org Git - nvme.git/commit
nvme: move stopping keep-alive into nvme_uninit_ctrl()
authorMing Lei <ming.lei@redhat.com>
Tue, 13 Aug 2024 01:35:27 +0000 (09:35 +0800)
committerKeith Busch <kbusch@kernel.org>
Thu, 22 Aug 2024 20:28:40 +0000 (13:28 -0700)
commita54a93d0e3599b05856971734e15418ac551a14c
tree6860c13c37c1db0b56eb30ed9833b49309814ef8
parent81475beb1b5996505a39cd1d9316ce1e668932a2
nvme: move stopping keep-alive into nvme_uninit_ctrl()

Commit 4733b65d82bd ("nvme: start keep-alive after admin queue setup")
moves starting keep-alive from nvme_start_ctrl() into
nvme_init_ctrl_finish(), but don't move stopping keep-alive into
nvme_uninit_ctrl(), so keep-alive work can be started and keep pending
after failing to start controller, finally use-after-free is triggered if
nvme host driver is unloaded.

This patch fixes kernel panic when running nvme/004 in case that connection
failure is triggered, by moving stopping keep-alive into nvme_uninit_ctrl().

This way is reasonable because keep-alive is now started in
nvme_init_ctrl_finish().

Fixes: 3af755a46881 ("nvme: move nvme_stop_keep_alive() back to original position")
Cc: Hannes Reinecke <hare@suse.de>
Cc: Mark O'Donovan <shiftee@posteo.net>
Reported-by: Changhui Zhong <czhong@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/core.c