]> www.infradead.org Git - users/jedix/linux-maple.git/commit
x86/resctrl: Fix arch_mbm_* array overrun on SNC
authorPeter Newman <peternewman@google.com>
Thu, 22 Aug 2024 19:02:11 +0000 (12:02 -0700)
committerBorislav Petkov (AMD) <bp@alien8.de>
Wed, 28 Aug 2024 09:13:08 +0000 (11:13 +0200)
commita547a5880cba6f287179135381f1b484b251be31
treec065e405cf2ba46e5860a5a549c5b9f9616b5279
parentb6fb565a2d15277896583d471b21bc14a0c99661
x86/resctrl: Fix arch_mbm_* array overrun on SNC

When using resctrl on systems with Sub-NUMA Clustering enabled, monitoring
groups may be allocated RMID values which would overrun the
arch_mbm_{local,total} arrays.

This is due to inconsistencies in whether the SNC-adjusted num_rmid value or
the unadjusted value in resctrl_arch_system_num_rmid_idx() is used. The
num_rmid value for the L3 resource is currently:

  resctrl_arch_system_num_rmid_idx() / snc_nodes_per_l3_cache

As a simple fix, make resctrl_arch_system_num_rmid_idx() return the
SNC-adjusted, L3 num_rmid value on x86.

Fixes: e13db55b5a0d ("x86/resctrl: Introduce snc_nodes_per_l3_cache")
Signed-off-by: Peter Newman <peternewman@google.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lore.kernel.org/r/20240822190212.1848788-1-peternewman@google.com
arch/x86/include/asm/resctrl.h
arch/x86/kernel/cpu/resctrl/core.c
include/linux/resctrl.h