]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/rockchip: vop2: make vp registers nonvolatile
authorPiotr Zalewski <pZ010001011111@proton.me>
Sun, 6 Jul 2025 08:36:58 +0000 (08:36 +0000)
committerHeiko Stuebner <heiko@sntech.de>
Thu, 14 Aug 2025 09:44:27 +0000 (11:44 +0200)
commita52dffaa46c2c5ff0b311c4dc1288581f7b9109e
treea88a08fd06d231e61bd61b86f5cecf00297de824
parentea177a1b1efc6e42e73ee4a17581842cd254e006
drm/rockchip: vop2: make vp registers nonvolatile

Make video port registers nonvolatile. As DSP_CTRL register is written
to twice due to gamma LUT enable bit which is set outside of the main
DSP_CTRL initialization within atomic_enable (for rk356x case it is also
necessary to always disable gamma LUT before writing a new LUT) there is
a chance that DSP_CTRL value read-out in gamma LUT init/update code is
not the one which was written by the preceding DSP_CTRL initialization
code within atomic_enable. This might result in misconfigured DSP_CTRL
which leads to no visual output[1]. Since DSP_CTRL write takes effect
after VSYNC[1] the issue is not always present. When tested on Pinetab2
with kernel 6.14 it happenes only when DRM is compiled as a module[1].
In order to confirm that it is a timing issue I inserted 18ms udelay
before vop2_crtc_atomic_try_set_gamma in atomic enable and compiled DRM
as module - this has also fixed the issue.

[1] https://lore.kernel.org/linux-rockchip/562b38e5.a496.1975f09f983.Coremail.andyshrk@163.com/

Reported-by: Diederik de Haas <didi.debian@cknow.org>
Closes: https://lore.kernel.org/linux-rockchip/DAEVDSTMWI1E.J454VZN0R9MA@cknow.org/
Suggested-by: Andy Yan <andy.yan@rock-chips.com>
Signed-off-by: Piotr Zalewski <pZ010001011111@proton.me>
Tested-by: Diederik de Haas <didi.debian@cknow.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20250706083629.140332-2-pZ010001011111@proton.me
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c