]> www.infradead.org Git - users/willy/pagecache.git/commit
caif_virtio: fix wrong pointer check in cfv_probe()
authorVitaliy Shevtsov <v.shevtsov@mt-integration.ru>
Thu, 27 Feb 2025 18:46:27 +0000 (23:46 +0500)
committerJakub Kicinski <kuba@kernel.org>
Sat, 1 Mar 2025 02:04:23 +0000 (18:04 -0800)
commita466fd7e9fafd975949e5945e2f70c33a94b1a70
treefbf46071ad3e0fce40c9363cd1de84767d6c53c2
parentee01b2f2d7d0010787c2343463965bbc283a497f
caif_virtio: fix wrong pointer check in cfv_probe()

del_vqs() frees virtqueues, therefore cfv->vq_tx pointer should be checked
for NULL before calling it, not cfv->vdev. Also the current implementation
is redundant because the pointer cfv->vdev is dereferenced before it is
checked for NULL.

Fix this by checking cfv->vq_tx for NULL instead of cfv->vdev before
calling del_vqs().

Fixes: 0d2e1a2926b1 ("caif_virtio: Introduce caif over virtio")
Signed-off-by: Vitaliy Shevtsov <v.shevtsov@mt-integration.ru>
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
Link: https://patch.msgid.link/20250227184716.4715-1-v.shevtsov@mt-integration.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/caif/caif_virtio.c