]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: phy: factor out provider part from mdio_bus.c
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 29 Apr 2025 06:04:46 +0000 (08:04 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 2 May 2025 01:03:29 +0000 (18:03 -0700)
commita3e1c0ad835702555d90565584ab6f723adf7f94
tree7a41c4dd999460fe0454305262b7280c26e6313a
parent51cf06ddafc91e017beecfaf81b3b082033b0b93
net: phy: factor out provider part from mdio_bus.c

After 52358dd63e34 ("net: phy: remove function stubs") there's a
problem if CONFIG_MDIO_BUS is set, but CONFIG_PHYLIB is not.
mdiobus_scan() uses phylib functions like get_phy_device().
Bringing back the stub wouldn't make much sense, because it would
allow to compile mdiobus_scan(), but the function would be unusable.
The stub returned NULL, and we have the following in mdiobus_scan():

phydev = get_phy_device(bus, addr, c45);
        if (IS_ERR(phydev))
                return phydev;

So calling mdiobus_scan() w/o CONFIG_PHYLIB would cause a crash later in
mdiobus_scan(). In general the PHYLIB functionality isn't optional here.
Consequently, MDIO bus providers depend on PHYLIB.
Therefore factor it out and build it together with the libphy core
modules. In addition make all MDIO bus providers under /drivers/net/mdio
depend on PHYLIB. Same applies to enetc MDIO bus provider. Note that
PHYLIB selects MDIO_DEVRES, therefore we can omit this here.

Fixes: 52358dd63e34 ("net: phy: remove function stubs")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504270639.mT0lh2o1-lkp@intel.com/
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/c74772a9-dab6-44bf-a657-389df89d85c2@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/enetc/Kconfig
drivers/net/mdio/Kconfig
drivers/net/phy/Makefile
drivers/net/phy/mdio_bus.c
drivers/net/phy/mdio_bus_provider.c [new file with mode: 0644]
include/linux/phy.h