]> www.infradead.org Git - users/jedix/linux-maple.git/commit
IB/ipoib: Remove ACL sysfs debug files
authorKa-Cheong Poon <ka-cheong.poon@oracle.com>
Fri, 20 Oct 2017 09:07:56 +0000 (02:07 -0700)
committerChuck Anderson <chuck.anderson@oracle.com>
Mon, 11 Dec 2017 04:20:08 +0000 (20:20 -0800)
commita37d6901204b4d00fa072224d6a9c8b8463e0b17
tree4548a342bb5368926d29b3f5280028987e43d497
parent27d5eb048ccbad313cc0bd656415784484ddf2b3
IB/ipoib: Remove ACL sysfs debug files

Currently, there are device attributes like add_acl which are writable and
can be used to add ACL in addition to using ioctl. The kernel needs to
parse a string from user space. While parsing IPv4 address is simple,
parsing IPv6 address is not. And it is error prone and can be a security
issue if not done right. Since those attributes are only used in a debug
kernel, it is advisable to remove those attributes instead of adding IPv6
support to them. The following attributes, add_acl, delete_acl, acl,
acl_instance, add_acl_instance and delete_acl_instance are removed. The
last four do not handle IP address. But to be consistent, they are also
removed.

Orabug: 25410192

Signed-off-by: Ka-Cheong Poon <ka-cheong.poon@oracle.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: HÃ¥kon Bugge <haakon.bugge@oracle.com>
drivers/infiniband/ulp/ipoib/ipoib_acl.c