]> www.infradead.org Git - users/dwmw2/linux.git/commit
floppy: fix div-by-zero in setup_format_params
authorDenis Efremov <efremov@ispras.ru>
Fri, 12 Jul 2019 18:55:20 +0000 (21:55 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 13 Aug 2019 11:39:26 +0000 (12:39 +0100)
commita36b6459cbff32a0ef228241c99d6586ca7e944c
tree53180d95a3a536b0a70a05a94be1dbb20195dd47
parent929606ae749185c940a5476d3a0e8d8e7c9c1db6
floppy: fix div-by-zero in setup_format_params

commit f3554aeb991214cbfafd17d55e2bfddb50282e32 upstream.

This fixes a divide by zero error in the setup_format_params function of
the floppy driver.

Two consecutive ioctls can trigger the bug: The first one should set the
drive geometry with such .sect and .rate values for the F_SECT_PER_TRACK
to become zero.  Next, the floppy format operation should be called.

A floppy disk is not required to be inserted.  An unprivileged user
could trigger the bug if the device is accessible.

The patch checks F_SECT_PER_TRACK for a non-zero value in the
set_geometry function.  The proper check should involve a reasonable
upper limit for the .sect and .rate fields, but it could change the
UAPI.

The patch also checks F_SECT_PER_TRACK in the setup_format_params, and
cancels the formatting operation in case of zero.

The bug was found by syzkaller.

Signed-off-by: Denis Efremov <efremov@ispras.ru>
Tested-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/block/floppy.c