]> www.infradead.org Git - users/jedix/linux-maple.git/commit
amdkfd: properly free gang_ctx_bo when failed to init user queue
authorZhu Lingshan <lingshan.zhu@amd.com>
Sun, 26 Jan 2025 09:21:10 +0000 (17:21 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 13 Feb 2025 00:47:15 +0000 (19:47 -0500)
commita33f7f9660705fb2ecf3467b2c48965564f392ce
treea182bc3faf25769978d46bce12c16da01efb152d
parent55ed2b1b50d029dd7e49a35f6628ca64db6d75d8
amdkfd: properly free gang_ctx_bo when failed to init user queue

The destructor of a gtt bo is declared as
void amdgpu_amdkfd_free_gtt_mem(struct amdgpu_device *adev, void **mem_obj);
Which takes void** as the second parameter.

GCC allows passing void* to the function because void* can be implicitly
casted to any other types, so it can pass compiling.

However, passing this void* parameter into the function's
execution process(which expects void** and dereferencing void**)
will result in errors.

Signed-off-by: Zhu Lingshan <lingshan.zhu@amd.com>
Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
Fixes: fb91065851cd ("drm/amdkfd: Refactor queue wptr_bo GART mapping")
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c