]> www.infradead.org Git - users/dwmw2/linux.git/commit
vmalloc: fix accounting with i915
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Wed, 11 Dec 2024 20:25:37 +0000 (20:25 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 19 Dec 2024 03:04:45 +0000 (19:04 -0800)
commita2e740e216f5bf49ccb83b6d490c72a340558a43
treec477631f64e3d4169d5127f7cb1388a8d15992f5
parentfaeec8e23c10bd30e8aa759a2eb3018dae00f924
vmalloc: fix accounting with i915

If the caller of vmap() specifies VM_MAP_PUT_PAGES (currently only the
i915 driver), we will decrement nr_vmalloc_pages and MEMCG_VMALLOC in
vfree().  These counters are incremented by vmalloc() but not by vmap() so
this will cause an underflow.  Check the VM_MAP_PUT_PAGES flag before
decrementing either counter.

Link: https://lkml.kernel.org/r/20241211202538.168311-1-willy@infradead.org
Fixes: b944afc9d64d ("mm: add a VM_MAP_PUT_PAGES flag for vmap")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Shakeel Butt <shakeel.butt@linux.dev>
Reviewed-by: Balbir Singh <balbirs@nvidia.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/vmalloc.c