]> www.infradead.org Git - users/jedix/linux-maple.git/commit
vsock/virtio: use GFP_ATOMIC under RCU read lock
authorMichael S. Tsirkin <mst@redhat.com>
Wed, 2 Oct 2024 13:35:20 +0000 (09:35 -0400)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 7 Oct 2024 15:47:55 +0000 (11:47 -0400)
commita194c985973276b2f280428c848f20369bb83734
treeb7f027a729a11184b7a3e5814937349f4a82f241
parentb9efbe2b8f0177fa97bfab290d60858900aa196b
vsock/virtio: use GFP_ATOMIC under RCU read lock

virtio_transport_send_pkt in now called on transport fast path,
under RCU read lock. In that case, we have a bug: virtio_add_sgs
is called with GFP_KERNEL, and might sleep.

Pass the gfp flags as an argument, and use GFP_ATOMIC on
the fast path.

Link: https://lore.kernel.org/all/hfcr2aget2zojmqpr4uhlzvnep4vgskblx5b6xf2ddosbsrke7@nt34bxgp7j2x
Fixes: efcd71af38be ("vsock/virtio: avoid queuing packets when intermediate queue is empty")
Reported-by: Christian Brauner <brauner@kernel.org>
Cc: Stefano Garzarella <sgarzare@redhat.com>
Cc: Luigi Leonardi <luigi.leonardi@outlook.com>
Message-ID: <3fbfb6e871f625f89eb578c7228e127437b1975a.1727876449.git.mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com>
Reviewed-by: Christian Brauner <brauner@kernel.org>
Reviewed-by: Luigi Leonardi <luigi.leonardi@outlook.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
net/vmw_vsock/virtio_transport.c