]> www.infradead.org Git - users/dwmw2/linux.git/commit
block, bfq: protect 'bfqd->queued' by 'bfqd->lock'
authorYu Kuai <yukuai3@huawei.com>
Fri, 13 May 2022 02:35:06 +0000 (10:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Nov 2022 17:14:24 +0000 (18:14 +0100)
commita0e2577cf3cca31e5ad1cbb3f5b68d5d2f5d83ee
tree4e48c686d40894326190e94babce3c0c08c1169a
parent26ca2ac091b49281d73df86111d16e5a76e43bd7
block, bfq: protect 'bfqd->queued' by 'bfqd->lock'

commit 181490d5321806e537dc5386db5ea640b826bf78 upstream.

If bfq_schedule_dispatch() is called from bfq_idle_slice_timer_body(),
then 'bfqd->queued' is read without holding 'bfqd->lock'. This is
wrong since it can be wrote concurrently.

Fix the problem by holding 'bfqd->lock' in such case.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20220513023507.2625717-2-yukuai3@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Cc: Khazhy Kumykov <khazhy@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
block/bfq-iosched.c