]> www.infradead.org Git - users/dwmw2/linux.git/commit
NFSD: fix problems with cleanup on errors in nfsd4_copy
authorDai Ngo <dai.ngo@oracle.com>
Tue, 31 Jan 2023 19:12:29 +0000 (11:12 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:19:26 +0000 (16:19 +0200)
commita0df1c3326e70b1320afceeb2f5e968910bdf336
treec030672a1e0f8f246ac9de73829f40aa62b1a1fe
parent22a0dd206a32d86494b84c0f61c3ed1dae51a916
NFSD: fix problems with cleanup on errors in nfsd4_copy

[ Upstream commit 81e722978ad21072470b73d8f6a50ad62c7d5b7d ]

When nfsd4_copy fails to allocate memory for async_copy->cp_src, or
nfs4_init_copy_state fails, it calls cleanup_async_copy to do the
cleanup for the async_copy which causes page fault since async_copy
is not yet initialized.

This patche rearranges the order of initializing the fields in
async_copy and adds checks in cleanup_async_copy to skip un-initialized
fields.

Fixes: ce0887ac96d3 ("NFSD add nfs4 inter ssc to nfsd4_copy")
Fixes: 87689df69491 ("NFSD: Shrink size of struct nfsd4_copy")
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4proc.c
fs/nfsd/nfs4state.c