]> www.infradead.org Git - users/dwmw2/linux.git/commit
ALSA: 6fire: Release resources at card release
authorTakashi Iwai <tiwai@suse.de>
Wed, 13 Nov 2024 11:10:39 +0000 (12:10 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 13 Nov 2024 12:33:47 +0000 (13:33 +0100)
commita0810c3d6dd2d29a9b92604d682eacd2902ce947
treee697682ee4027cc29f0cd36dc7533cc39c451101
parentb04dcbb7f7b1908806b7dc22671cdbe78ff2b82c
ALSA: 6fire: Release resources at card release

The current 6fire code tries to release the resources right after the
call of usb6fire_chip_abort().  But at this moment, the card object
might be still in use (as we're calling snd_card_free_when_closed()).

For avoid potential UAFs, move the release of resources to the card's
private_free instead of the manual call of usb6fire_chip_destroy() at
the USB disconnect callback.

Fixes: c6d43ba816d1 ("ALSA: usb/6fire - Driver for TerraTec DMX 6Fire USB")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20241113111042.15058-6-tiwai@suse.de
sound/usb/6fire/chip.c