]> www.infradead.org Git - users/dwmw2/linux.git/commit
HID: sony: Fix memory corruption issue on cleanup.
authorRoderick Colenbrander <roderick.colenbrander@sony.com>
Wed, 4 Sep 2019 21:22:11 +0000 (14:22 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 Oct 2019 07:01:37 +0000 (09:01 +0200)
commita069e96b5280177ee73732f42aabfddb1483dd45
tree91173629950f859688e29b10484e08a5736cec31
parent5f2ba05924ca5c4ff668e7404db281779f2633de
HID: sony: Fix memory corruption issue on cleanup.

commit 2bcdacb70327013ca2066bfcf2af1009eff01f1d upstream.

The sony driver is not properly cleaning up from potential failures in
sony_input_configured. Currently it calls hid_hw_stop, while hid_connect
is still running. This is not a good idea, instead hid_hw_stop should
be moved to sony_probe. Similar changes were recently made to Logitech
drivers, which were also doing improper cleanup.

Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
CC: stable@vger.kernel.org
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-sony.c