]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PCI: keystone: Don't enable BAR 0 for AM654x
authorSiddharth Vadapalli <s-vadapalli@ti.com>
Thu, 28 Mar 2024 08:50:41 +0000 (14:20 +0530)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 28 May 2024 16:15:15 +0000 (11:15 -0500)
commit9ffa0e70b2daf9b0271e4960b7c8a2350e2cda08
tree2477d77a291505be83be42f829e2b2de657fc0b4
parent5125fdc3292eea20870d4e6cefa62dc1245ce7ec
PCI: keystone: Don't enable BAR 0 for AM654x

After 6ab15b5e7057 ("PCI: dwc: keystone: Convert .scan_bus() callback to
use add_bus"), ks_pcie_v3_65_add_bus() enabled BAR 0 for both v3.65a and
v4.90a devices.  On the AM654x SoC, which uses v4.90a, enabling BAR 0
causes Completion Timeouts when setting up MSI-X.  These timeouts delay
boot of the AM654x by about 45 seconds.

Move the BAR 0 initialization to ks_pcie_msi_host_init(), which is only
used for v3.65a devices, and remove ks_pcie_v3_65_add_bus().

[bhelgaas: commit log]
Fixes: 6ab15b5e7057 ("PCI: dwc: keystone: Convert .scan_bus() callback to use add_bus")
Link: https://lore.kernel.org/linux-pci/20240328085041.2916899-3-s-vadapalli@ti.com
Suggested-by: Bjorn Helgaas <helgaas@kernel.org>
Suggested-by: Niklas Cassel <cassel@kernel.org>
Suggested-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Krzysztof WilczyƄski <kwilczynski@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
drivers/pci/controller/dwc/pci-keystone.c