]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf cpumap: Fix die and cluster IDs
authorJames Clark <james.clark@linaro.org>
Wed, 18 Dec 2024 11:55:51 +0000 (11:55 +0000)
committerNamhyung Kim <namhyung@kernel.org>
Tue, 28 Jan 2025 18:03:26 +0000 (10:03 -0800)
commit9fae5884bb0e3480dbb69314b82ed3d8f8482eef
tree50b5099901bef20332d41d383848cbf4a02f51a8
parent72d81e10628be6a948463259cbb6d3b670b20054
perf cpumap: Fix die and cluster IDs

Now that filename__read_int() returns -errno instead of -1 these
statements need to be updated otherwise error values will be used as
die IDs.

This appears as a -2 die ID when the platform doesn't export one:

  $ perf stat --per-core -a -- true

  S36-D-2-C0            1               9.45 msec cpu-clock

And the session topology test fails:

  $ perf test -vvv topology

  CPU 0, core 0, socket 36
  CPU 1, core 1, socket 36
  CPU 2, core 2, socket 36
  CPU 3, core 3, socket 36
  FAILED tests/topology.c:137 Cpu map - Die ID doesn't match
  ---- end(-1) ----
  38: Session topology                                                : FAILED!

Fixes: 05be17eed774 ("tool api fs: Correctly encode errno for read/write open failures")
Reported-by: Thomas Richter <tmricht@linux.ibm.com>
Signed-off-by: James Clark <james.clark@linaro.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20241218115552.912517-1-james.clark@linaro.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/cpumap.c