]> www.infradead.org Git - users/dwmw2/linux.git/commit
btrfs: validate device maj:min during open
authorAnand Jain <anand.jain@oracle.com>
Fri, 1 Mar 2024 00:42:13 +0000 (08:42 +0800)
committerDavid Sterba <dsterba@suse.com>
Tue, 26 Mar 2024 15:42:38 +0000 (16:42 +0100)
commit9f7eb8405dcbc79c5434821e9e3e92abe187ee8e
tree7f99d51bf300140ba4bcf413930e2a2e8692eb52
parent1ec17ef59168a1a6f1105f5dc517f783839a5302
btrfs: validate device maj:min during open

Boris managed to create a device capable of changing its maj:min without
altering its device path.

Only multi-devices can be scanned. A device that gets scanned and remains
in the btrfs kernel cache might end up with an incorrect maj:min.

Despite the temp-fsid feature patch did not introduce this bug, it could
lead to issues if the above multi-device is converted to a single device
with a stale maj:min. Subsequently, attempting to mount the same device
with the correct maj:min might mistake it for another device with the same
fsid, potentially resulting in wrongly auto-enabling the temp-fsid feature.

To address this, this patch validates the device's maj:min at the time of
device open and updates it if it has changed since the last scan.

CC: stable@vger.kernel.org # 6.7+
Fixes: a5b8a5f9f835 ("btrfs: support cloned-device mount capability")
Reported-by: Boris Burkov <boris@bur.io>
Co-developed-by: Boris Burkov <boris@bur.io>
Reviewed-by: Boris Burkov <boris@bur.io>#
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/volumes.c