]> www.infradead.org Git - users/jedix/linux-maple.git/commit
dmaengine: dw-edma: Do not enable watermark interrupts for HDMA
authorMrinmay Sarkar <quic_msarkar@quicinc.com>
Mon, 26 Aug 2024 12:11:01 +0000 (17:41 +0530)
committerVinod Koul <vkoul@kernel.org>
Wed, 28 Aug 2024 13:10:17 +0000 (18:40 +0530)
commit9f646ff25c09c52cebe726601db27a60f876f15e
tree13ac1a9b46f964f93c2d309ac3b2d989117807c2
parent383baf5c8f062091af34c63f28d37642a8f188ae
dmaengine: dw-edma: Do not enable watermark interrupts for HDMA

DW_HDMA_V0_LIE and DW_HDMA_V0_RIE are initialized as BIT(3) and BIT(4)
respectively in dw_hdma_control enum. But as per HDMA register these
bits are corresponds to LWIE and RWIE bit i.e local watermark interrupt
enable and remote watermarek interrupt enable. In linked list mode LWIE
and RWIE bits only enable the local and remote watermark interrupt.

Since the watermark interrupts are not used but enabled, this leads to
spurious interrupts getting generated. So remove the code that enables
them to avoid generating spurious watermark interrupts.

And also rename DW_HDMA_V0_LIE to DW_HDMA_V0_LWIE and DW_HDMA_V0_RIE to
DW_HDMA_V0_RWIE as there is no LIE and RIE bits in HDMA and those bits
are corresponds to LWIE and RWIE bits.

Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA")
cc: stable@vger.kernel.org
Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Link: https://lore.kernel.org/r/1724674261-3144-3-git-send-email-quic_msarkar@quicinc.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dw-edma/dw-hdma-v0-core.c