]> www.infradead.org Git - users/dwmw2/linux.git/commit
ice: check (DD | EOF) bits on Rx descriptor rather than (EOP | RS)
authorMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Thu, 7 Jul 2022 10:20:42 +0000 (12:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Aug 2022 10:00:45 +0000 (12:00 +0200)
commit9ed6f97c8d77d0c06a70bc0189bf4c0cc8fd0144
treeb8de546a89102b3c9d2b10f80a58e9991430a7cc
parent2b4b373271e5a39117f520dfa931f2f801f3076f
ice: check (DD | EOF) bits on Rx descriptor rather than (EOP | RS)

commit 283d736ff7c7e96ac5b32c6c0de40372f8eb171e upstream.

Tx side sets EOP and RS bits on descriptors to indicate that a
particular descriptor is the last one and needs to generate an irq when
it was sent. These bits should not be checked on completion path
regardless whether it's the Tx or the Rx. DD bit serves this purpose and
it indicates that a particular descriptor is either for Rx or was
successfully Txed. EOF is also set as loopback test does not xmit
fragmented frames.

Look at (DD | EOF) bits setting in ice_lbtest_receive_frames() instead
of EOP and RS pair.

Fixes: 0e674aeb0b77 ("ice: Add handler for ethtool selftest")
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/intel/ice/ice_ethtool.c