]> www.infradead.org Git - users/hch/block.git/commit
pidfd: change do_notify_pidfd() to use __wake_up(poll_to_key(EPOLLIN))
authorOleg Nesterov <oleg@redhat.com>
Mon, 5 Feb 2024 14:13:48 +0000 (15:13 +0100)
committerChristian Brauner <brauner@kernel.org>
Tue, 6 Feb 2024 12:52:51 +0000 (13:52 +0100)
commit9ed52108f6478a6a805c0c15a3f70aabba07247e
treeae72cf409d3f9d977eccd94b9eeb140c0ac2ed13
parenta1c6d5439fbddd06aad3ddbb7f12df0b98354070
pidfd: change do_notify_pidfd() to use __wake_up(poll_to_key(EPOLLIN))

rather than wake_up_all(). This way do_notify_pidfd() won't wakeup the
POLLHUP-only waiters which wait for pid_task() == NULL.

TODO:
    - as Christian pointed out, this asks for the new wake_up_all_poll()
      helper, it can already have other users.

    - we can probably discriminate the PIDFD_THREAD and non-PIDFD_THREAD
      waiters, but this needs more work. See
      https://lore.kernel.org/all/20240205140848.GA15853@redhat.com/

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/r/20240205141348.GA16539@redhat.com
Reviewed-by: Tycho Andersen <tandersen@netflix.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
kernel/signal.c