]> www.infradead.org Git - users/jedix/linux-maple.git/commit
bpf: Check negative offsets in __bpf_skb_min_len()
authorCong Wang <cong.wang@bytedance.com>
Fri, 13 Dec 2024 03:40:54 +0000 (19:40 -0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 20 Dec 2024 22:13:31 +0000 (23:13 +0100)
commit9ecc4d858b92c1bb0673ad9c327298e600c55659
treead4cc5de86b1a3c6304cbc6d0053a2e49ddbcdf6
parent5153a75ef34b3f7478ca918044d0f05eed8fb3f9
bpf: Check negative offsets in __bpf_skb_min_len()

skb_network_offset() and skb_transport_offset() can be negative when
they are called after we pull the transport header, for example, when
we use eBPF sockmap at the point of ->sk_data_ready().

__bpf_skb_min_len() uses an unsigned int to get these offsets, this
leads to a very large number which then causes bpf_skb_change_tail()
failed unexpectedly.

Fix this by using a signed int to get these offsets and ensure the
minimum is at least zero.

Fixes: 5293efe62df8 ("bpf: add bpf_skb_change_tail helper")
Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20241213034057.246437-2-xiyou.wangcong@gmail.com
net/core/filter.c