]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ext4: avoid overflow when setting values via sysfs
authorBaokun Li <libaokun1@huawei.com>
Tue, 19 Mar 2024 11:33:17 +0000 (19:33 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 3 May 2024 03:48:30 +0000 (23:48 -0400)
commit9e8e819f8f272c4e5dcd0bd6c7450e36481ed139
tree536b7ca43144d10b089cb32277e40e923cf396a8
parentc77194965dd0dcc26f9c1671d2e74e4eb1248af5
ext4: avoid overflow when setting values via sysfs

When setting values of type unsigned int through sysfs, we use kstrtoul()
to parse it and then truncate part of it as the final set value, when the
set value is greater than UINT_MAX, the set value will not match what we
see because of the truncation. As follows:

  $ echo 4294967296 > /sys/fs/ext4/sda/mb_max_linear_groups
  $ cat /sys/fs/ext4/sda/mb_max_linear_groups
    0

So we use kstrtouint() to parse the attr_pointer_ui type to avoid the
inconsistency described above. In addition, a judgment is added to avoid
setting s_resv_clusters less than 0.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20240319113325.3110393-2-libaokun1@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/sysfs.c