]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: i2c: adv748x: Fix test pattern selection mask
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Tue, 21 Jan 2025 20:44:00 +0000 (21:44 +0100)
committerHans Verkuil <hverkuil@xs4all.nl>
Fri, 21 Feb 2025 09:33:04 +0000 (10:33 +0100)
commit9e38acacb9d809b97a0bdc5c76e725355a47158a
tree7cdd3705d42d5064caa81316b2b78e23a5a52655
parent22d3d1f0d1abbae71e7404cee1ece91ce8441669
media: i2c: adv748x: Fix test pattern selection mask

The mask to select the test-pattern in register ADV748X_SDP_FRP is
incorrect, it's the lower 3 bits which controls the pattern. The
GENMASK() macro is used incorrectly and the generated mask is 0x0e
instead of 0x07.

The result is that not all test patterns are selectable, and that in
some cases the wrong test pattern is activated. Fix this by correcting
the GENMASK().

Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver")
Cc: stable@vger.kernel.org
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
[hverkuil: fixed tiny typo in commit log: my -> by]
drivers/media/i2c/adv748x/adv748x.h