]> www.infradead.org Git - nvme.git/commit
accel/habanalabs: use kcalloc() instead of kzalloc()
authorErick Archer <erick.archer@gmx.com>
Sat, 20 Jan 2024 15:10:28 +0000 (16:10 +0100)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 26 Feb 2024 07:30:41 +0000 (09:30 +0200)
commit9e263c5042d0cb7ed62e499345533c349db30d3f
treea99fda2508ffdf10844ba19e21c1a41260c80840
parent5ae8b6b774732d38840dd7562dc14d1950530023
accel/habanalabs: use kcalloc() instead of kzalloc()

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
size * count in the kzalloc() function.

Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Erick Archer <erick.archer@gmx.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/accel/habanalabs/common/mmu/mmu_v1.c