]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: axienet: Fix race condition causing TX hang
authorRobert Hancock <hancock@sedsystems.ca>
Thu, 6 Jun 2019 22:28:17 +0000 (16:28 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Jul 2019 05:28:23 +0000 (07:28 +0200)
commit9da3f199ab6a1c384fe366fb6ae99af451b85dde
tree6171c03340a083c0ae333377771339f111a9d744
parenta9f11461782e9cf31b7940f166ff9e50e57a52e7
net: axienet: Fix race condition causing TX hang

[ Upstream commit 7de44285c1f69ccfbe8be1d6a16fcd956681fee6 ]

It is possible that the interrupt handler fires and frees up space in
the TX ring in between checking for sufficient TX ring space and
stopping the TX queue in axienet_start_xmit. If this happens, the
queue wake from the interrupt handler will occur before the queue is
stopped, causing a lost wakeup and the adapter's transmit hanging.

To avoid this, after stopping the queue, check again whether there is
sufficient space in the TX ring. If so, wake up the queue again.

Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/xilinx/xilinx_axienet_main.c