]> www.infradead.org Git - users/jedix/linux-maple.git/commit
tcp: fix potential huge kmalloc() calls in TCP_REPAIR
authorEric Dumazet <edumazet@google.com>
Thu, 19 Nov 2015 05:03:33 +0000 (21:03 -0800)
committerChuck Anderson <chuck.anderson@oracle.com>
Fri, 5 Feb 2016 03:33:12 +0000 (19:33 -0800)
commit9d9de7ac4766390f178f5618c688ce42f7a32a4b
tree66f6a8d81968394e48d5fbd4941328dec2586f89
parent90bf1b0c047a7141bac1ecff9be1bbc047c72f11
tcp: fix potential huge kmalloc() calls in TCP_REPAIR

Orabug: 22623857

[ Upstream commit 5d4c9bfbabdb1d497f21afd81501e5c54b0c85d9 ]

tcp_send_rcvq() is used for re-injecting data into tcp receive queue.

Problems :

- No check against size is performed, allowed user to fool kernel in
  attempting very large memory allocations, eventually triggering
  OOM when memory is fragmented.

- In case of fault during the copy we do not return correct errno.

Lets use alloc_skb_with_frags() to cook optimal skbs.

Fixes: 292e8d8c8538 ("tcp: Move rcvq sending to tcp_input.c")
Fixes: c0e88ff0f256 ("tcp: Repair socket queues")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Acked-by: Pavel Emelyanov <xemul@parallels.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit ddb686ac700f589d138b39c5306d04299cb805a2)
Signed-off-by: Dan Duval <dan.duval@oracle.com>
net/ipv4/tcp_input.c