]> www.infradead.org Git - users/jedix/linux-maple.git/commit
counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of TIM_DIER_CCxIE(x)
authorUwe Kleine-König <u.kleine-koenig@baylibre.com>
Wed, 19 Jun 2024 10:11:44 +0000 (12:11 +0200)
committerLee Jones <lee@kernel.org>
Wed, 26 Jun 2024 15:09:55 +0000 (16:09 +0100)
commit9d7809aaea0fb569a9707975d37a170dc0111761
tree23c8b845e61945f6b536c11c6733574535e2f7d1
parent796b942f65967af55684bf520812787b97522151
counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of TIM_DIER_CCxIE(x)

These two defines have the same purpose and this change doesn't
introduce any differences in drivers/counter/stm32-timer-cnt.o.

The only difference between the two is that

TIM_DIER_CC_IE(1) == TIM_DIER_CC2IE

while

TIM_DIER_CCxIE(1) == TIM_DIER_CC1IE

. That makes it necessary to have an explicit "+ 1" in the user code,
but IMHO this is a good thing as this is the code locatation that
"knows" that for software channel 1 you have to use TIM_DIER_CC2IE
(because software guys start counting at 0, while the relevant hardware
designer started at 1).

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Acked-by: William Breathitt Gray <wbg@kernel.org>
Link: https://lore.kernel.org/r/126bd153a03f39e42645573eecf44ffab5354fc7.1718791090.git.u.kleine-koenig@baylibre.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/counter/stm32-timer-cnt.c